Remove C++ style comments from quantifier offset comment

[GoogleCodeExporter]

Quantifier offset comment in C files is declared in the C++ style.  Please
change to C syntax.  (i.e., /* .. */ )

Thanks!

Original issue reported on code.google.com by AdamJMo...@gmail.com on 9 Sep 2008 at 10:21

[GoogleCodeExporter]

i already fixed this in 0.3.  For example:

%grep quantifier_offset protobuf-c-0.4/src/google/protobuf/compiler/c/*
protobuf-c-0.4/src/google/protobuf/compiler/c/c_field.cc:     
printer->Print(variables, "  0,   /* quantifier_offset */\n");
protobuf-c-0.4/src/google/protobuf/compiler/c/c_field.cc:      
printer->Print(variables, "  0,   /* quantifier_offset */\n");

Also:
% svn log -r55

r55 | lahiker42 | 2008-08-27 23:08:40 -0700 (Wed, 27 Aug 2008) | 3 lines

- suppress final enum comma
- do not use c++ comments

------------------------------------------------------------------------
% svn diff -r54:55 src/google/protobuf/compiler/c/c_field.cc  
Index: src/google/protobuf/compiler/c/c_field.cc
===================================================================
--- src/google/protobuf/compiler/c/c_field.cc   (revision 54)
+++ src/google/protobuf/compiler/c/c_field.cc   (revision 55)
@@ -61,13 +61,13 @@
     "  PROTOBUF_C_TYPE_$TYPE$,\n");
   switch (descriptor_->label()) {
     case FieldDescriptor::LABEL_REQUIRED:
-      printer->Print(variables, "  0,   // quantifier_offset\n");
+      printer->Print(variables, "  0,   /* quantifier_offset */\n");
       break;
     case FieldDescriptor::LABEL_OPTIONAL:
       if (optional_uses_has) {
        printer->Print(variables, "  PROTOBUF_C_OFFSETOF($classname$, has_$name$
),\n");
       } else {
-       printer->Print(variables, "  0,   // quantifier_offset\n");
+       printer->Print(variables, "  0,   /* quantifier_offset */\n");
       }
       break;

I think you need to regenerate your files.  (You should add a Makefile 
dependency on
protoc-c so that if protoc-c changes you will rebuild it...)

Original comment by lahike...@gmail.com on 9 Sep 2008 at 11:57

[GoogleCodeExporter]

Please reopen this bug if it continues to be a problem.

Original comment by lahike...@gmail.com on 12 Sep 2008 at 1:52

[GoogleCodeExporter]

Original comment by lahike...@gmail.com on 12 Sep 2008 at 1:52

• Changed state: Invalid