digideskio / zotonic

Automatically exported from code.google.com/p/zotonic
0 stars 0 forks source link

Cannot add to menu #189

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
I now get the following error when adding a new item to a menu in Zotonic:

Error in routing drop to module "resource_menu_admin_menu"; error: "undef"

I am running from mercurial tip.

Original issue reported on code.google.com by connor...@gmail.com on 25 Jul 2011 at 12:18

GoogleCodeExporter commented 8 years ago
Thanks for entering the report. Can you paste the full error message?

Original comment by scherpenisse on 25 Jul 2011 at 12:42

GoogleCodeExporter commented 8 years ago
Sure:

=ERROR REPORT==== 26-Jul-2011::11:08:59 ===
scomp_base_droppable:83 Error in drop routing: undef
[{resource_menu_admin_menu,event,
     [{drop,
          {dragdrop,["new",325],action_base_typeselect,"vqgxpclf-connect-325"},
          {dragdrop,
              [330,"before",[3]],
              resource_menu_admin_menu,"xvhwia-before-3"}},
      {context,
          {wm_reqdata,#Port<0.17020>,
              {dict,2,16,16,8,80,48,

Original comment by connor...@gmail.com on 26 Jul 2011 at 9:10

GoogleCodeExporter commented 8 years ago
Having only spent 24hours with the code, please feel free to ignore my comment, 
but I think this is related to rev:2a04468d9889. Your comments say 
"long overdue cleanup of templates and old code. Fix nl translations." 

In that revision you deleted 
/modules/mod_menu/resources/resource_menu_admin_menu.erl which seems like its 
required on a drop. (at least scomp_base_droppable.erl is trying to call that 
modules event/2). 

That said, adding it that dir and file back only made the error message go away 
but didnt solve the problem (cant add new menu items). 

Original comment by k4p1...@gmail.com on 1 Aug 2011 at 4:17

GoogleCodeExporter commented 8 years ago
That sounds like a regression indeed... I might have been too rigorous in that 
rev.
I'll try to reproduce. This might call for a bugfix release...

Original comment by scherpenisse on 1 Aug 2011 at 8:29

GoogleCodeExporter commented 8 years ago
D'oh, I indeed removed some code which was still needed but did not delete the 
.beam file, so it seemed it still worked.

Original comment by scherpenisse on 1 Aug 2011 at 8:34

GoogleCodeExporter commented 8 years ago
This issue was closed by revision bad335c41985.

Original comment by scherpenisse on 1 Aug 2011 at 8:42

GoogleCodeExporter commented 8 years ago

Original comment by scherpenisse on 1 Aug 2011 at 8:42

GoogleCodeExporter commented 8 years ago
Thanks! 

Btw, you may want to update the notes for release 0.7. I would imagine a lot of 
people stumbling over this one.

Original comment by k4p1...@gmail.com on 2 Aug 2011 at 2:29