search

digidotcom / python-streamexpect

Python library providing cross-platform text matching for generic streams and sockets
Mozilla Public License 2.0
41 stars 8 forks source link

Add support for python 3.10 #6

Closed almetge closed 2 years ago

almetge commented 2 years ago

Python 3.10 moved the Sequence type under collections.abc, rendering it incompatible with previous versions. Try to import with this new location and fallback to previous location to keep backward compatibility with Python2.

setuptools-mardown is now deprecated, in favor of the long_description_content_type argument in setup.py. This replacement is done because the setuptools-mardown library depends on any version of pypandoc and is now broken with the latest version (1.8) which removed a function that was used, causing this error: AttributeError: module 'pypandoc' has no attribute 'convert'

In setup.py, the setup_require key is now deprecated, and has been removed since build build only needed setuptools-mardown which is no longer needed. In setup.py, the test_suite and tests_require keys are now deprecated, in favor of an external testing tool. The tox configuration file now contain the description of the required test dependencies.

Nose is replaced by pytest in this commit, mainly because I was unable to run any test using it, and pytest worked as a drop-in replacement.

Regarding the nose to pytest change, I might be simply missing something and can be reverted it if needed.

jorgenhauge commented 2 years ago

Any progress on this? When can we expect it to be merged? Thanks, Jorgen

nastevens commented 2 years ago

Sorry for the delay on this, I didn't realize I'd been given the ability to review and merge PRs (I'm no longer employed by Digi). Might be time for a new PyPI release as well, it's only been six years...

Thanks!