Add macOS foreign configuration

digikar99 / py4cl2-cffi

CFFI based alternative to py4cl2

43 stars 10 forks source link

Add macOS foreign configuration #2

Closed plandes closed 1 year ago

plandes commented 1 year ago

This adds macOS as a foreign configuration. I split it out as a separate package because:

Provides for a cleaner separation from the config package as it is a significant chunk of code.
Allows better a finer level of potential customization to clients.

This pull request also make the compilation command itself a global customizable variable (*python-compile-command*). Doing so made the customization easier to write and allows clients to make other fine tuned adjustments that might be necessary for their respective platforms.

plandes commented 1 year ago

@digikar99 Sorry, I thought I had put that back--but to answer your question: I am working on this part now. When I run fiveam unit tests I've written for my own library from Roswell, this fails because numpy is not in Python's sys.path. To make matter worse, traceback is not imported by the time the numpy library is imported so you get a failure without error reporting.

digikar99 commented 1 year ago

I see, in that case, feel free to raise an issue! The rest of the things here look good. Thank you for the PR!

plandes commented 1 year ago

@digikar99 Thank you. This has been resolved in the last pull request. Let me know if you disagree with any of these changes as the evaluation is fairly different. While I was not able to run your unit tests, I have my own that have passed.