search

digimezzo / dopamine-windows

Audio player which tries to make organizing and listening to music as simple and pretty as possible.
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.83k stars 258 forks source link

Showing Discs and Album Size #1064

Open chadfranklin47 opened 4 years ago

chadfranklin47 commented 4 years ago

I'm submitting a...


[ ] Regression 
[ ] Bug report  
[x] Feature request

Hello again, I have noticed that when I have multiple discs in an album and when I look at the tracks in Dopamine, Dopamine indicates which tracks fall under which discs WHEN THE FILES ARE M4A. If the files are FLAC, then Dopamine just lists the files straight without indicating what disc they are in and it gets confusing. Is this by design? Can this be changed or fixed? Also, is it by design that a 2.83 GB album shows the size "2 GB" in dopamine? I think it would be better to round to the nearest whole number, but it's not that big of a deal.

Screenshots: image

vs

image

And in this case, the album songs add up to 2.81GB as shown here: image

digimezzo commented 4 years ago

@chadfranklin47 Could you attach some screenshots to indicate where you are seeing and not seeing the disc info and wrong size calculation? Thanks!

digimezzo commented 4 years ago

@chadfranklin47 Are the "Disc number" tags filled in for all these files?

chadfranklin47 commented 4 years ago

@digimezzo Yes, the disc numbers are filled in, at least according to Mp3tag. Also, this is the case for multiple, if not all, FLAC albums I have, not just one.

digimezzo commented 4 years ago

@chadfranklin47 Ok. Thanks for the info. I'll look at it.

chadfranklin47 commented 4 years ago

@digimezzo Thank you.

digimezzo commented 4 years ago

@chadfranklin47 I fixed the album size bug. I'll be in the next release (which will be Beta 1). i'm now looking into the disc issue.

digimezzo commented 4 years ago

@chadfranklin47 The disc thing is not an issue. Please check the "Disc count" tag on your mp3 files. The discs are only split up when the disc count tag is set. Without that info, Dopamine cannot know there is more than 1 disc.

I'm guessing that your m4a files have the disc count set properly. Could you confirm this?

chadfranklin47 commented 4 years ago

@digimezzo Just to reiterate, I have only ever gotten the bug with FLAC files. The files were tagged correctly, but it seems the bug has something to do with FLAC itself, maybe an older version of FLAC is buggy as converting all of my files from FLAC to FLAC using the newest version of foobar2000 fixes the problem. Here is a link to a short video displaying the problem files and the fixed ones. The only difference between them is the album name and me doing the conversion with foobar:

https://youtu.be/PHu94bR9uFs

digimezzo commented 4 years ago

@chadfranklin47 Thanks a lot for the extra info and video. That really helpful. I'm just wondering, can Dopamine see the disc number info? To check this, could you right click on one of the oolder flac files that still has that issue, and choose "Edit" (that should open the Dopamine tag editor). Could yo utell me if the disc number tag is filled in there? Thanks

chadfranklin47 commented 4 years ago

@digimezzo Ok, I see it now. Dopamine can see the Disc Number for the old files but not the Disc Count. While with the new files, it sees both. But as far as I know, Disc Count isn't something that I set manually, is it? Mp3tag only has a tag for DiscNumber, not DiscCount. Same with Track count. And I didn't change anything for the new files, all I did was convert from FLAC to FLAC with the newest foobar2000. Here is the screenshot for the old files:

image

and the new files:

image

chadfranklin47 commented 4 years ago

@digimezzo Is Disc Count and Track Count just a Dopamine thing or a thing embedded in the files? Is there a way for the code to not rely on those attributes? It seems doable with just the track number and the disc number.

chadfranklin47 commented 4 years ago

@digimezzo Small update, I get the same error on one of my Ogg formatted albums.

digimezzo commented 4 years ago

@chadfranklin47 The choice of using the disc count instead of track number and disc number is related to performance. When using disc number, 2 passes over the whole list of selected tracks would be required to know if an album consists of more than 1 disc (Dopamine would have to check the disc numbers for all tracks of an album, and see if there are different disc numbers). Disc count immediately shows if there is more than 1 disc, on the 1st pass. That is much faster. So that logic will probably never change.

Disc count and disc number are indeed tags that are embedded in the files. I'm not sure what is wrong with the Flac and Ogg files though. And equally unsure why re-encoding flac files resolves the issue. Would you mind sharing a flac and ogg file which still have this issue, so I could have a closer look?

chadfranklin47 commented 4 years ago

Ok, I see @digimezzo . Absolutely. Here is a download link containing a zip file of one track from the FLAC album, one from the Ogg album, and the same FLAC track after re-encoding which fixes the problem:

https://mega.nz/#!PmwUXCCb!wKaE8o3QGxrwzftmTskpqMZ1ygV0ZmZiqpOQFCs8u4w

digimezzo commented 4 years ago

@chadfranklin47 Excellent, I've downloaded them. Thanks!