Memory Leak with Song Covers - Githubissues

digimezzo / dopamine-windows

Audio player which tries to make organizing and listening to music as simple and pretty as possible.

https://digimezzo.github.io/site/

GNU General Public License v3.0

1.81k stars 258 forks source link

Memory Leak with Song Covers #1327

Open TacoEarth opened 3 years ago

TacoEarth commented 3 years ago

I'm submitting a...


[ ] Regression 
[x ] Bug report  
[ ] Feature request

I'm using these versions

Windows version: Windows 10 21H1 19043
Dopamine version: 2.0.8

Reproduction steps

Step 1 Play songs with many album covers
Step 2 Hit Next song
Step 3 Memory usage increases and cache never flushes

Observed behavior

Memory usage keeps increasing ## Desired behavior Memory and cache of album covers and other data should flush every 10 or so songs ## Log file

2021-06-22 00:00:31.950|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:00:32.357|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Brian the Sun - HEROES(Boku no Hero Academia).mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:00:33.996|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:00:34.818|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Dagashi Kashi OST - 48° Hey! Calorie Queen.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:00:39.478|Info|PlaybackService.SaveQueuedTracksAsync|503|Saved 336 queued tracks 2021-06-22 00:02:07.379|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:02:07.746|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Eye-Water Attack On Titan.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:02:09.388|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:02:10.009|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:02:10.352|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 1.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:02:12.029|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:02:37.080|Info|TrayControls.xaml.Show|26|Showing tray controls 2021-06-22 00:02:37.091|Info|TrayControls.xaml.SetGeometry|91|Tray controls position: Taskbar position = Bottom, Left = 1615px, Top = 780px 2021-06-22 00:02:38.528|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:02:38.867|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 10.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:02:40.552|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:02:42.369|Info|TrayControls.xaml.Show|26|Showing tray controls 2021-06-22 00:02:42.376|Info|TrayControls.xaml.SetGeometry|91|Tray controls position: Taskbar position = Bottom, Left = 1615px, Top = 780px 2021-06-22 00:02:45.147|Info|PlaybackService.PlaybackFinishedHandler|1240|Track finished: C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 10.mp3 2021-06-22 00:02:45.310|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 10.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:02:47.157|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:02:54.944|Info|TrayControls.xaml.Show|26|Showing tray controls 2021-06-22 00:02:54.951|Info|TrayControls.xaml.SetGeometry|91|Tray controls position: Taskbar position = Bottom, Left = 1615px, Top = 780px 2021-06-22 00:03:10.380|Info|PlaybackService.PlaybackFinishedHandler|1240|Track finished: C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 10.mp3 2021-06-22 00:03:10.526|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 10.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:03:12.392|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:03:20.616|Info|TrayControls.xaml.Show|26|Showing tray controls 2021-06-22 00:03:20.622|Info|TrayControls.xaml.SetGeometry|91|Tray controls position: Taskbar position = Bottom, Left = 1615px, Top = 780px 2021-06-22 00:03:22.056|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:03:22.344|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 11.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:03:24.000|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:03:24.263|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 12.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:03:25.344|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:03:25.597|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\Fairy Tail Ending 13.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=False 2021-06-22 00:03:27.372|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:03:33.713|Info|TrayControls.xaml.Show|26|Showing tray controls 2021-06-22 00:03:33.718|Info|TrayControls.xaml.SetGeometry|91|Tray controls position: Taskbar position = Bottom, Left = 1615px, Top = 780px 2021-06-22 00:03:36.088|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:03:36.401|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\My Hero Academia OST Theme Song.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=True 2021-06-22 00:03:38.112|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:03:48.040|Info|PlaybackService.PlaybackFinishedHandler|1240|Track finished: C:\Users\taco\Music\Weaboogaloo\My Hero Academia OST Theme Song.mp3 2021-06-22 00:03:48.175|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\Weaboogaloo\My Hero Academia OST_ Theme Song.mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=True 2021-06-22 00:03:50.067|Info|PlaybackService.SavePlaybackCountersAsync|542|Saved track statistics 2021-06-22 00:05:23.529|Info|TrayControls.xaml.Show|26|Showing tray controls 2021-06-22 00:05:23.535|Info|TrayControls.xaml.SetGeometry|91|Tray controls position: Taskbar position = Bottom, Left = 1615px, Top = 780px 2021-06-22 00:05:24.440|Info|PlaybackService.PlayNextAsync|647|Request to play the next track. 2021-06-22 00:05:24.828|Info|PlaybackService.TryPlayAsync|1130|Playing the file C:\Users\taco\Music\The Dank Collection\CaptainSparklez - Revenge (Creeper, Aww Man).mp3. EventMode=False, ExclusiveMode=False, LoopMode=One, Shuffle=True

ghost commented 3 years ago

I love your folder's names. Also, I can attest to the memory leak, it happens to me as well. OS: Windows 11. Latest Dopamine version.