Lyrics timestamps don't work when longer than 1 hour - Githubissues

digimezzo / dopamine-windows

Audio player which tries to make organizing and listening to music as simple and pretty as possible.

https://digimezzo.github.io/site/

GNU General Public License v3.0

1.89k stars 266 forks source link

Lyrics timestamps don't work when longer than 1 hour #382

Closed digimezzo closed 7 years ago

digimezzo commented 7 years ago

A user notified me of this issue:

Hello, I use the lyrics page for dj mix tracklist scrolling, but I have a problem with it: if the track is longer than an hour, the timestamps don't manage it properly. Is there a solution for this?

When the timestamp is longer than 1 hour, only the minutes are saved, the hour is chopped off.

digimezzo commented 7 years ago

The LRC file format is not documented in regards to timestamps which are longer than 1 hour. I couldn't find any documentation about this anyway. So I inspired this edit by how MusicBee implements timestamps which are longer than 1 hour. The "minutes" part of the timestamp can contain minutes which are higher than 60.