search

digimezzo / dopamine-windows

Audio player which tries to make organizing and listening to music as simple and pretty as possible.
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.88k stars 263 forks source link

Wrong bit rate for opus tracks #601

Open Keith94 opened 6 years ago

Keith94 commented 6 years ago

Opus files report bit rate as 0 kbps in Dopamine 1.5.5 You can test with the track here: https://github.com/digimezzo/Dopamine/issues/590#issuecomment-349221734

image

Keith94 commented 6 years ago

Aforementioned track is encoded with --bitrate 512 --vbr FWIW

digimezzo commented 6 years ago

Could be related to https://github.com/taglib/taglib/issues/251 and https://github.com/mono/taglib-sharp/issues/83

digimezzo commented 6 years ago

Ok it is indeed related to the bug linked above. Tablibsharp still returns a hardcoded 0 for the opus bitrate. See: https://github.com/mono/taglib-sharp/blob/master/src/TagLib/Ogg/Codecs/Opus.cs

public int AudioBitrate {
    get {return 0;}
}
digimezzo commented 6 years ago

I haven't figured out how to calculate the bitrate yet. Any help is appreciated.