digimezzo / dopamine-windows

Audio player which tries to make organizing and listening to music as simple and pretty as possible.
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.84k stars 260 forks source link

Audio Converter #652

Open Riajyuu opened 6 years ago

Riajyuu commented 6 years ago

I'm submitting a...


[ ] Regression 
[ ] Bug report  
[x] Feature request

Please add a audio converter. This means you have to pack all common libraries into your installer.

Check how AIMP and foobar2000 implement this.

digimezzo commented 6 years ago

Edited the the feature request to respect the provided template.

KrayZeee commented 6 years ago

why? i would prefer that the player doesnt do more jobs than necessary. if you have problems playing music get a app which is specialized in converting encodings, it will in general do a better job then implementing a half assed mediaconverter into an audioplayer, not mentioning the downsides this is bringing.

i dont want to be rude, but pls no.

Riajyuu commented 6 years ago

@KrayZeee have you ever purchased digital iso online? When you got one, after exact audio copy, you will get a large wav. If you need to break them out, audio converter is necessary. You will know what I am talking about if you have tried.

KrayZeee commented 6 years ago

i know what you mean, but ripping audio to your prefered format shouldnt be the job of the player. there are tons of tools which you can use to convert your files and then disregard the converter again when it isnt need anymore. its not like you are ripping audio cds every day.

there is no reason to bloat a player which would have to load all these libraries resulting in worse performance. the code would have to be maintained, and maybe even licensing could be an issue (mp3)

many, me included, love dopamine because it is slick and does what it is intended to in the most sexy way. giving it converter abilities is like giving your hot girlfriend too much chocolate until she gets fat.

Riajyuu commented 6 years ago

@KrayZeee perhaps you have misunderstood something here. Those libraries will not be loaded unless you start converting. More specific example: both amip & fb2k break this into an independent exe and release the library as soon as conversation complete. So I am also requesting the author to learn magic from them. So performance impact is really not necessary to be concerned here.

KrayZeee commented 6 years ago

jea right but at the same time these player are the impersonation of all the reasons i dont want to use them.

while you are right in regards to the library performance point, if properly implemented, it is still work which would have to be done. meanwhile i dont see the reason for this, great some other player can do this, and? if i buy a cd player, it will also not rip cds for me, why would i have to expect it from the softwareversion of a player?

and assuming a converter gets implemented, whats next? movies? music creation?

what i want to say is that playing music and ripping music are 2 fundamentally different tasks. if there are some apps which combine this, great, but you dont have to follow every lead

digimezzo commented 6 years ago

@KrayZeee shares the vision that I've been having for Dopamine since the beginning: keep it simple. It was designed just because other players are bloated. The success of Dopamine relies mostly on that. Some people just want something simple and good-looking to play their songs. So, at the moment, there are no plans to add a audio converter.

Magentaize commented 6 years ago

I also don't think it's a good idea. Once audio converter has been added in it, every time when I start a converting progress, my library will be polluted by the raw copy.