search

digimezzo / dopamine

The audio player that keeps it simple
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.44k stars 109 forks source link

.tiff cover images don't load #482

Open DopamineUser opened 9 months ago

DopamineUser commented 9 months ago

^ title image

digimezzo commented 9 months ago

Tiff is currently not supported, but I can add that. Where are these tiff images located (in relation to the audio files) and what are the file names?

DopamineUser commented 9 months ago

Cover.tiff Embedded within audio file

digimezzo commented 9 months ago

Could you share one of those files? I'd like to test this out.

DopamineUser commented 9 months ago

TestFiles.zip

digimezzo commented 5 months ago

@DopamineUser Did you test this with preview 25 https://github.com/digimezzo/dopamine/releases/tag/v3.0.0-preview.25 also? It has an extra fix for images compared to the nighty that you tested.

DopamineUser commented 5 months ago

@DopamineUser Did you test this with preview 25 https://github.com/digimezzo/dopamine/releases/tag/v3.0.0-preview.25 also? It has an extra fix for images compared to the nighty that you tested.

just tried installing it and got this image re-downloaded and the same thing happened

digimezzo commented 5 months ago

@DopamineUser Wow that's not good. I have it too here and am trying to find out what went wrong.

digimezzo commented 5 months ago

@DopamineUser Should be fixed now. I re-uploaded the Windows package, downloaded it and launched it and it works here now. It must have been an upload problem.

DopamineUser commented 5 months ago

@DopamineUser Did you test this with preview 25 https://github.com/digimezzo/dopamine/releases/tag/v3.0.0-preview.25 also? It has an extra fix for images compared to the nighty that you tested.

image sadly no difference

digimezzo commented 5 months ago

@DopamineUser I'm fixing that for you. You can expect a nightly with the fix in a few hours.

digimezzo commented 5 months ago

@DopamineUser Your nightly is ready: https://github.com/digimezzo/dopamine/actions/runs/8131733170

DopamineUser commented 5 months ago

@DopamineUser Your nightly is ready: https://github.com/digimezzo/dopamine/actions/runs/8131733170

thanks :) works now

also there's a bug you missed: after launching dopamine, playing something and then opening the now playing screen for the first time, it says no track is currently playing.

oh nevermind i just saw you made an issue already lol

digimezzo commented 5 months ago

@DopamineUser This nightly fixes the now playing issue: https://github.com/digimezzo/dopamine/actions/runs/8132923641

digimezzo commented 4 weeks ago

Tiff is probably broken again due to fixing issue #633. I had no other option. This will be looked at later.