search

digimezzo / dopamine

The audio player that keeps it simple
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.39k stars 108 forks source link

[Bug] Very Poor Performance #577

Closed DopamineUser closed 4 months ago

DopamineUser commented 4 months ago

Ever since updating to preview24, dopamine is very very slow and taking up to 28% CPU (Intel i5) when im interacting with it, and around 13% when its minimized (the visualizer is disabled).

Also, when dopamine's window is in focus, my PC stops going into screen saver mode, which wasn't the case before this update.

[error] [AlbumArtworkCache] [addArtworkDataToCacheAsync] Could not add artwork data to cache. Error: maxMemoryUsageInMB limit exceeded by at least 37MB

also noticed this in the logs

HilloBerries commented 4 months ago

Same here

Patrock404 commented 4 months ago

I've also noticed this, I switched back to preview 23.

digimezzo commented 4 months ago

Could you all add your logs to this issue?

Is performance also bad when you disable refreshing of collection in the settings and restart dopamine?

DopamineUser commented 4 months ago

Is performance also bad when you disable refreshing of collection in the settings and restart dopamine?

That fixed it, as well as the screen saver problem.

digimezzo commented 4 months ago

@DopamineUser Thank you for testing that out. I made big changes to the indexer and wanted to know if the performance issues were related to that. Could you also attach your full log to this issue? I want to undertand if indexing gets stuck on your system. As it is not happening on my computer. Thanks.

Crocodile73 commented 4 months ago

Same issues for me. Disabling automatic refresh help performance. But its stuck on updating album covers. Has no covers for any.

digimezzo commented 4 months ago

@Crocodile73 Thank you so much for confirming this. Indexing of album covers is causing problems for multiple users. So that seems like a good place to start looking.

digimezzo commented 4 months ago

Note to self: this could be a "Jimp" issue. See: https://github.com/jimp-dev/jimp/issues/915

DopamineUser commented 4 months ago

@DopamineUser Thank you for testing that out. I made big changes to the indexer and wanted to know if the performance issues were related to that. Could you also attach your full log to this issue? I want to undertand if indexing gets stuck on your system. As it is not happening on my computer. Thanks. Dopamine.log

Pelintra81 commented 4 months ago

I also have poor performance since the last update. Turning off collection automatically refresh doesn't help.

digimezzo commented 4 months ago

@Pelintra81 @DopamineUser @Crocodile73 @HilloBerries @Patrock404

Could you try the latest nightly which is here: https://github.com/digimezzo/dopamine/actions/runs/8107139535

That's essentially a release candidate for preview 25. It should fix the performance issues. Please let me know if it solves your issues.

DopamineUser commented 4 months ago

Could you try the latest nightly which is here: https://github.com/digimezzo/dopamine/actions/runs/8107139535

everything works properly now, and .tiff images work.

Crocodile73 commented 4 months ago

Everything is running fine for me also now.

HilloBerries commented 4 months ago

@Pelintra81 @DopamineUser @Crocodile73 @HilloBerries @Patrock404

Could you try the latest nightly which is here: https://github.com/digimezzo/dopamine/actions/runs/8107139535

That's essentially a release candidate for preview 25. It should fix the performance issues. Please let me know if it solves your issues.

Yes, this fixes it for me. Runs very smooth now.

digimezzo commented 4 months ago

Thanks all for testing out the nightly!

Pelintra81 commented 4 months ago

It's working fine here now, thank you!

DopamineUser commented 4 months ago

everything works properly now, and .tiff images work.

actually, .tiff covers only display on the "pages", not the now playing screen or the playing bar