search

digimezzo / dopamine

The audio player that keeps it simple
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.48k stars 110 forks source link

Make Button Foreground Colors Theme-able #583

Closed dermeck closed 6 months ago

dermeck commented 7 months ago

There are a few places where the background of elements is affected by the color theme but the foreground is not. This makes some things hard to read, when light primary/secondary colors are configured and the foreground is hard coded to white.

One example is the artist header, but there are a few places where: background: linear-gradient(45deg, var(--theme-primary-color) 30%, var(--theme-secondary-color) 100%); or background: var(--theme-accent-color); is set in combination with color: white.

I'd be happy to tackle it if you want. I'm not sure if every case should get its own variable or if it's primary-button-text. I'd probably go with one new variable highlight-text-color.

digimezzo commented 7 months ago

@dermeck Thank you for reporting this. It makes sense to have this color in a new variable. Feel free to create a pull request. I'll gladly review it.

dermeck commented 7 months ago

@digimezzo the related PR is here: https://github.com/digimezzo/dopamine/pull/585