Pressing 'Space' key when editing Playlist toggles play

digimezzo / dopamine

The audio player that keeps it simple

https://digimezzo.github.io/site/

GNU General Public License v3.0

1.39k stars 108 forks source link

Pressing 'Space' key when editing Playlist toggles play #589

Closed dermeck closed 3 months ago

dermeck commented 4 months ago

Pressing Space while Creating/Editing Playlist and Playlist Folders should not toggle the play/pause.

I'd be happy to tackle this. There seems to be a check for isInputDialogOpened missing. Although I suggest to check for the input target instead (prevent keyboard controlling the player whenever an input is the target).

digimezzo commented 4 months ago

@dermeck Please do. I'm open for help on this matter :) Thanks!

dermeck commented 3 months ago

@digimezzo the PR is here https://github.com/digimezzo/dopamine/pull/591

I am not sure why it is not linked automatically to the issue. :thinking: