digimezzo / dopamine

The audio player that keeps it simple
https://digimezzo.github.io/site/
GNU General Public License v3.0
1.48k stars 110 forks source link

fix #589 prevent toggle play via Space key when typing into an input #591

Closed dermeck closed 6 months ago

dermeck commented 6 months ago

Prevents toogling play/pause when 'Space' key is pressed and an input is the event target.

The two flags in the DialogService and SearchService were removed because they were no longer needed. I am not sure if those will be needed in the future (I can re-add those if you want). For now there was only one more usages besides the "Space key press" which is the focus styling of the search box. That could be solved by :focus-within.

digimezzo commented 6 months ago

Nice PR! Thank you!