fix #584 show albums and tracks when filtering for genres via search text

digimezzo / dopamine

The audio player that keeps it simple

https://digimezzo.github.io/site/

GNU General Public License v3.0

1.39k stars 108 forks source link

Closed dermeck closed 2 months ago

dermeck commented 3 months ago

This is split into two commits because I'm not sure if the second commit is "too much" and should be reverted.

the first one is the actual fix:

the second one is a rafactoring:

first collects the relevant text and only calls the searchService once, which (subjectively) also makes the test a bit easier

digimezzo commented 3 months ago

Thanks for this PR! And sorry for the delay in reviewing this. I'll review it this week.

dermeck commented 3 months ago

No worries - I'm aware that this is a side project :) .

digimezzo commented 2 months ago

@dermeck Thanks again for this PR. The fix looks great! I'm merging it.