search

diginex / gwallet

gwallet is a minimalistic and pragmatist opensource lightweight crossplatform brainwallet for people that want to hold the most important cryptocurrencies in the same application with ease and peace of mind
MIT License
25 stars 10 forks source link

Should support "ethereum:" URL scheme #67

Closed knocte closed 4 years ago

knocte commented 5 years ago

See https://gitlab.com/diginex/gwallet/issues/67

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.38 ETH (49.96 USD @ $131.48/ETH) attached to it.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 9 months, 2 weeks from now. Please review their action plans below:

1) janus has been approved to start work.

I have started off , and would push my commit after morning discussion

Learn more on the Gitcoin Issue Details page.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 0.64 ETH (88.6 USD @ $138.44/ETH) .

gitcoinbot commented 5 years ago

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

janus commented 5 years ago

Sure .. still working on it

On Sun, Mar 24, 2019 at 5:16 PM Gitcoin.co Bot notifications@github.com wrote:

@janus https://github.com/janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=1 | 3 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=3 | 5 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=5 | 10 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=10 | 100 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=100

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diginex/geewallet/issues/67#issuecomment-475973822, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAaRpLPoT_NmrdT26wVIWd4C_hgItajks5vZ6TKgaJpZM4bCHBq .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

gitcoinbot commented 5 years ago

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

janus commented 5 years ago

Yed

On Tue, Apr 2, 2019, 5:15 PM Gitcoin.co Bot notifications@github.com wrote:

@janus https://github.com/janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=1 | 3 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=3 | 5 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=5 | 10 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=10 | 100 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=100

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diginex/geewallet/issues/67#issuecomment-479074703, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAaRs7v4gmExbtvq2BLizEGmbqyiZB-ks5vc4I0gaJpZM4bCHBq .

gitcoinbot commented 5 years ago

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

janus commented 5 years ago

Yes

On Mon, Apr 8, 2019 at 5:15 PM Gitcoin.co Bot notifications@github.com wrote:

@janus https://github.com/janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=1 | 3 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=3 | 5 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=5 | 10 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=10 | 100 days https://gitcoin.co/issue/diginex/geewallet/67/2603?snooze=100

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diginex/geewallet/issues/67#issuecomment-480899356, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAaRjRklgPqecf8ZWgysG4TuVFafGnBks5ve2sogaJpZM4bCHBq .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

gitcoinbot commented 5 years ago

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@janus due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.64 ETH (174.11 USD @ $272.04/ETH) has been submitted by:

  1. @janus

@knocte please take a look at the submitted work:

janus commented 5 years ago

@owocki , I have submitted my work for more than 4 months now, and I have also reached out to the funder. But he has not done anything that could lead to the closing of this. This has limited me from participating in other open bounties. Please help me get the funder to act, or get me paid so that my labour would not be in vain.

owocki commented 5 years ago

@knocte can you pls payout/respond to the PR? thanks.

knocte commented 5 years ago

The PR (in GitLab jargon called MR) doesn't even pass CI so it's unacceptable.

knocte commented 5 years ago

For reference: https://gitlab.com/knocte/geewallet/merge_requests/39 (see the red "X" icons)

janus commented 5 years ago

Please where is the ci that is linked to this pr/mr . You never mentioned this until now after 4 months .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

knocte commented 5 years ago

Where is the CI? What kind of question is this Emeka? By now you should already know that CI means the gitlabCI jobs that are created in the MergeRequest.

janus commented 5 years ago

Andre

https://gitlab.com/Akaa/geewallet/-/jobs/184338600

Please have a look . If you are referring to above they are Electricintegrationtest something unrelated to what I did for you.

If you have another ci in mind , please point it out .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

knocte commented 5 years ago

Ah ok, sorry. I guess I forgot about this because the MR is really old. These days those integration tests are disabled so if you rebase the MR the CI will become green.

Nonetheless, now I start to remember that this MR was blocked on a different thing, that we discussed offline (in chat, instead of the MR). I'll double check this.

knocte commented 5 years ago

I'll double check this.

Double-checked, and added a comment about this in the MR.

janus commented 5 years ago

The issue you posted out is not about the task but the structure you want your code base to take . I don't think I should be made to toil in vain, and what you pointed is not task not done, nor tests failing .

I urge you to be courageous, and pay me.

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

knocte commented 5 years ago

The issue you posted out is not about the task but the structure you want your code base to take .

It's not about structure, it's about compatibility. The wallet can be run with Mono 4.6.x (the one that Ubuntu bundles), Mono 6.x (the official stable version that you can get in macOS and in Ubuntu if you use Microsoft apt sources) and Microsoft.NET. If you hardcode a path to an assembly that only exists in Mono 4.6.x then the wallet will crash in Windows (because of using MS.NET instead of Mono), and in OSs where Mono 6.x is used (macOS and Ubuntu when using Microsoft apt repositories). We cannot merge an MR that would make the wallet crash. As simple as this.

janus commented 5 years ago

@owocki,

What do you mean integration? Gitcoin works only in one way: the bounty is collected if the MR is merged. This MR cannot be merged as is, it has this problem that needs to be solved. If you find this problem too complex then this project is not for you.

It is pretty obvious to me now that Andre does not want to pay . I am not asking him for handout but to honour a contract. He is now hiding under non related and trivial issue. I would ask for arbitration team to take over this issue.

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

knocte commented 5 years ago

I would ask for abstraction team to take over this issue.

I don't know what you mean by "abstraction team" but yeah sure, be my guest, I invite everyone to check out the MR and my comments and how it needs a rebase, etc.

janus commented 5 years ago

not about structure, it's about compatibility. The wallet can be run with Mono 4.6.x (the one that Ubuntu bundles), Mono 6.x (the official stable version that you can get in macOS and in Ubuntu if you use Microsoft apt sources) and Microsoft.NET. If you hardcode a path to an assembly that only exists in Mono 4.6.x then the wallet will crash in Windows (because of using MS.NET http://ms.net/ instead of Mono), and in OSs where Mono 6.x is used (macOS and Ubuntu when using Microsoft apt repositories). We cannot merge an MR that would make the wallet crash. As simple as this.

You are a programmer , and why opening such on gitcoin bounties if your code base can't accept such .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

knocte commented 5 years ago

You are programmer , and why opening such gotcoin ticket if your code base can't accept such .

This sentence doesn't make any sense to me.

janus commented 5 years ago

Stop shifting the goal post .... honor a contract.

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

owocki commented 5 years ago

hey all; lets take a day off from this issue. ill broker a mutually acceptable solution after we take some tim eoff to brethe

janus commented 5 years ago

@owocki

Any update?

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

owocki commented 5 years ago

im giving it a couple days to cool off. im going to circle back after that.

janus commented 5 years ago

@owocki , Please circle back. Justice delayed is justice denied.

owocki commented 5 years ago

@janus i told you i was on it; please stop harassing me with reminders every several days, and thereby implying that you distrust that i will get back to you. i said i would circle back and i will. meantime, please take some ownership of reigning in your confrontational tone, which got you into an argument with the funder and us into a situation in which i needed to step in in the first place.

janus commented 5 years ago

@owocki,

Please I am withdrawing this issue ...and I am closing this case . Thanks for your time.

Andrea, I highly appreciated the opportunity you offered me.

Once again thank you all .

On Tuesday, September 17, 2019, Kevin Owocki notifications@github.com wrote:

@janus https://github.com/janus i told you i was on it; please stop harassing me with reminders every several days, and thereby implying that you distrust that i will get back to you. i said i would circle back and i will. meantime, please take some ownership of reigning in your confrontational tone, which got you into an argument with the funder and us into a situation in which i needed to step in in the first place.

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

gitcoinbot commented 5 years ago

⚡️ A tip worth 0.19000 ETH (39.75 USD @ $209.22/ETH) has been granted to @janus for this issue from @owocki. ⚡️

The sender had the following public comments:

i am funding half of the reward for this contributor for their effort/time here. if anyone else wants to cover the other half be my guest

Nice work @janus! Your tip has automatically been deposited in the ETH address we have on file.

knocte commented 4 years ago

Repo moved to GNOME's gitlab, so moving this issue to here: https://gitlab.gnome.org/World/geewallet/issues/67