search

diginex / gwallet

gwallet is a minimalistic and pragmatist opensource lightweight crossplatform brainwallet for people that want to hold the most important cryptocurrencies in the same application with ease and peace of mind
MIT License
25 stars 10 forks source link

Should check if ETH/ETC destination address is a contract or not #69

Open knocte opened 5 years ago

knocte commented 5 years ago

See https://gitlab.com/diginex/gwallet/issues/69

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 0.08 ETH (11.71 USD @ $146.41/ETH) attached to it.

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months, 1 week from now. Please review their action plans below:

1) janus has been approved to start work.

This is me the chap that you assigned this task to...

As I wrote to you the other day , I would take 2 weeks to get up to speed with your choice language and programming environment. And I would be doing this task in 1-3 hours.

Once again thanks for this opportunity .

Learn more on the Gitcoin Issue Details page.

knocte commented 5 years ago

@e18r hey sorry, @janus contacted me first to work on this. If in 2 weeks there's no progress I'll pass it to you ;)

gitcoinbot commented 5 years ago

@janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

janus commented 5 years ago

I am still working on it

On Sat, Feb 23, 2019 at 6:16 PM Gitcoin.co Bot notifications@github.com wrote:

@janus https://github.com/janus Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day https://gitcoin.co/issue/diginex/geewallet/69/2429?snooze=1 | 3 days https://gitcoin.co/issue/diginex/geewallet/69/2429?snooze=3 | 5 days https://gitcoin.co/issue/diginex/geewallet/69/2429?snooze=5 | 10 days https://gitcoin.co/issue/diginex/geewallet/69/2429?snooze=10 | 100 days https://gitcoin.co/issue/diginex/geewallet/69/2429?snooze=100

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diginex/geewallet/issues/69#issuecomment-466670273, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAaRqQcNnzK8vZtsrL8m6RhgNVgMhO3ks5vQXdqgaJpZM4bCIcs .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com

janus commented 5 years ago

https://gist.github.com/janus/29a24b21d972446ce1861d44a0e28b96 The above is for @knocte to pass his comment before .. I update and add to the code base

janus commented 5 years ago

https://gitlab.com/DiginexGlobal/geewallet/merge_requests/28

Please , @knocte , review my code

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of this issue was increased to 0.17 ETH (23.2 USD @ $136.47/ETH) .

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 0.17 ETH (21.24 USD @ $124.94/ETH) has been submitted by:

  1. @janus

@knocte please take a look at the submitted work:

knocte commented 5 years ago

PR link is wrong, this is the correct link: https://gitlab.com/DiginexGlobal/geewallet/merge_requests/29

gitcoinbot commented 5 years ago

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

The funding of 0.17 ETH (21.24 USD @ $124.94/ETH) attached to this issue has been approved & issued to @janus.

janus commented 5 years ago

Sorry for that

On Mon, Mar 4, 2019 at 1:03 PM Andres G. Aragoneses < notifications@github.com> wrote:

PR link is wrong, this is the correct link: https://gitlab.com/DiginexGlobal/geewallet/merge_requests/29

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/diginex/geewallet/issues/69#issuecomment-469228636, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAaRrIXh0rtsDSSdzMeVQ0W62i9OhBwks5vTQuGgaJpZM4bCIcs .

-- P.S Please join our groups: nigeriaarduinogroup@googlegroups.com