search

digininja / CeWL

CeWL is a Custom Word List Generator
1.9k stars 255 forks source link

Add missing `r` to RUBYOPT in Dockerfile #111

Closed r3motecontrol closed 4 months ago

r3motecontrol commented 4 months ago

I tried to build the docker image and got this error. After digging on Google and Github, I found that the -rubygems flag is deprecated as of Ruby 2.5. After adding the missing r to RUBYOPT, I successfully built the container image.

12.89 + gem install bundler
12.94 <internal:/usr/local/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require': cannot load such file -- ubygems (LoadError)
12.94 Did you mean?  rubygems
12.94   from <internal:/usr/local/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in `require'
------
Dockerfile:9
--------------------
   8 |     RUN apk add gcompat
   9 | >>> RUN set -ex \
  10 | >>>     && apk add  --no-cache --virtual .build-deps build-base \
  11 | >>>     && gem install bundler \
  12 | >>>     && bundle install \
  13 | >>>     && apk del .build-deps
  14 |
--------------------
ERROR: failed to solve: process "/bin/sh -c set -ex     && apk add  --no-cache --virtual .build-deps build-base     && gem install bundler     && bundle install     && apk del .build-deps" did not complete successfully: exit code: 1

https://github.com/rubygems/rubygems/issues/2393#issuecomment-421626674

@loris-intergalactique can you please review the MR?

loris-intergalactique commented 4 months ago

Sure, I'll do so right after i get back in front of a computer, I'll keep you updated

Le dim. 28 avr. 2024, 21:05, Ravi Buddi @.***> a écrit :

I tried to build the docker image and got this error. After digging on Google and Github, I found that the -rubygems flag is deprecated as of Ruby 2.5. After adding the missing r to RUBYOPT, I successfully built the container image.

12.89 + gem install bundler 12.94 <internal:/usr/local/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:in require': cannot load such file -- ubygems (LoadError) 12.94 Did you mean? rubygems 12.94 from <internal:/usr/local/lib/ruby/3.3.0/rubygems/core_ext/kernel_require.rb>:136:inrequire'

Dockerfile:9

8 | RUN apk add gcompat 9 | >>> RUN set -ex \ 10 | >>> && apk add --no-cache --virtual .build-deps build-base \ 11 | >>> && gem install bundler \ 12 | >>> && bundle install \ 13 | >>> && apk del .build-deps 14 |

ERROR: failed to solve: process "/bin/sh -c set -ex && apk add --no-cache --virtual .build-deps build-base && gem install bundler && bundle install && apk del .build-deps" did not complete successfully: exit code: 1

rubygems/rubygems#2393 (comment) https://github.com/rubygems/rubygems/issues/2393#issuecomment-421626674

@loris-intergalactique https://github.com/loris-intergalactique can you please review the MR?

You can view, comment on, or merge this pull request online at:

https://github.com/digininja/CeWL/pull/111 Commit Summary

File Changes

(1 file https://github.com/digininja/CeWL/pull/111/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/digininja/CeWL/pull/111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMIYDENDR6OI4WHU64QYXCLY7VCATAVCNFSM6AAAAABG5GLOCSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DONZUGM3DMMY . You are receiving this because you were mentioned.Message ID: @.***>

loris-intergalactique commented 4 months ago

LGTM,

@digininja this can be merged

digininja commented 4 months ago

Thanks everyone.