Closed 5p1n closed 5 years ago
Looks ok, have you got a site I can easily test it on?
I've been using this website for testing purposes: https://www.studying-in-germany.org/german-umlauts/
That seems like one that would be pretty good for looking at umlauts. I'll give your change a test and see, but it looks ok.
On Wed, 27 Nov 2019 at 13:57, 5p1n notifications@github.com wrote:
I've been using this website for testing purposes: https://www.studying-in-germany.org/german-umlauts/
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/digininja/CeWL/pull/55?email_source=notifications&email_token=AAA4SWP7JLRCDAJTMMTK6O3QVZ4GHA5CNFSM4JSGKAQKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFJSR7Q#issuecomment-559098110, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWMHWJ7IUPS7FD42P2DQVZ4GHANCNFSM4JSGKAQA .
I've just merged the lowercase as that was easier to test but now I'm getting conflicts. If you are any good with Git, can you fix them and update this PR.
If not, I'll have a go later.
Should be good to go.
Thanks.
This new parameter adds functionality to convert the common Latin-1 umlauts ä, ö, ü and ß to ae, oe, ue and ss