digininja / DVWA

Damn Vulnerable Web Application (DVWA)
GNU General Public License v3.0
10.34k stars 3.63k forks source link

Command Injection Vulnerability a better teaching example #630

Closed m-fedosov closed 6 months ago

m-fedosov commented 6 months ago

It makes sense to use implode and explode in pairs, and a shorter check is_numeric

digininja commented 6 months ago

I'm going to say no to this one, it may be a better way to do it from a developers point of view, but for a learner to look at it and understand what it is doing, the current way is better.