search

digininja / DVWA

Damn Vulnerable Web Application (DVWA)
GNU General Public License v3.0
10.36k stars 3.64k forks source link

Improve code readability #634

Open m-fedosov opened 6 months ago

m-fedosov commented 6 months ago

I've kept the same checks, but replaced or removed unnecessary instructions that can be confusing to a beginner

m-fedosov commented 6 months ago

Let's pull this one into master

digininja commented 6 months ago

You don't seem to be getting the online comments so I'll try again.

I don't like echo compared to dropping out of php so I'd reject all of those.

On high, you've lost a 500 response code.

On impossible, can you do something other than ??, I don't think that improves readability.

On Sat, 25 May 2024, 21:14 m-fedosov, @.***> wrote:

Let's pull this one into master

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/634#issuecomment-2131425678, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWOTALSHASTWFQPFCUTZEDWKVAVCNFSM6AAAAABHR67RL2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZRGQZDKNRXHA . You are receiving this because you commented.Message ID: @.***>