search

digininja / DVWA

Damn Vulnerable Web Application (DVWA)
GNU General Public License v3.0
10.36k stars 3.64k forks source link

Added a new installation script which runs in english with more Improvements and better execution command #639

Closed its-ashu-otf closed 5 months ago

digininja commented 5 months ago

What is the difference between your script and @IamCarron's script, it is too much effort to diff the two.

its-ashu-otf commented 5 months ago

The @IamCarron's script doesn't run with english language in kali-linux and I've done some corrections in syntax too. also there is no need to download my script you can just copy paste this one command and get going. :) Also I've worked on more error handling

its-ashu-otf commented 5 months ago

Btw Love your Project ❤️

digininja commented 5 months ago

It does work in English, you can specify English or Spanish.

On Tue, 11 Jun 2024, 20:48 Ashutosh, @.***> wrote:

The @IamCarron https://github.com/IamCarron's script doesn't run with english language in kali-linux and I've done some corrections in syntax too. also there is no need to download my script you can just copy paste this one command and get going. :) Also I've worked on more error handling

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161494558, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWJSGP6HWXELYMQO2D3ZG5ICLAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGQ4TINJVHA . You are receiving this because you commented.Message ID: @.***>

its-ashu-otf commented 5 months ago

the automatic detection of language doesn't works sir. as u can see image

digininja commented 5 months ago

It used to work, how are you running it? Can you show the command line you used?

On Tue, 11 Jun 2024, 20:53 Ashutosh, @.***> wrote:

the automatic detection of language doesn't works sir. as u can see image.png (view on web) https://github.com/digininja/DVWA/assets/85825366/a82391b0-fb70-4950-b2f6-1cbfbbeae0b0

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161501952, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWNMBYR3FGOSZ3XKEV3ZG5IVNAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGUYDCOJVGI . You are receiving this because you commented.Message ID: @.***>

its-ashu-otf commented 5 months ago
  1. wget https://raw.githubusercontent.com/IamCarron/DVWA-Script/main/Install-DVWA.sh
  2. chmod +x Install-DVWA.sh
  3. sudo ./Install-DVWA.sh

image

digininja commented 5 months ago

Asking because it looks like it was ran with either sh or a different shell rather than bash.

I'm interested to know why it stopped working if it has as it did used to work.

I'll check it and you're version out when I get chance over the next few days.

On Tue, 11 Jun 2024, 20:58 Ashutosh, @.***> wrote:

  1. wget https://raw.githubusercontent.com/IamCarron/DVWA-Script/main/Install-DVWA.sh
  2. chmod +x Install-DVWA.sh
  3. sudo ./Install-DVWA.sh

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161508516, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWJSN54AP5XHBM43VWTZG5JFXAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGUYDQNJRGY . You are receiving this because you commented.Message ID: @.***>

its-ashu-otf commented 5 months ago

let me check in bash shell too sir

Checked out it's same issue in the bash shell too

IamCarron commented 5 months ago

Hello, @its-ashu-otf ,

I recently ran the installer on the latest version of Kali using the default shell. It worked fine for me. I believe the errors you encountered may depend on the shell you used.

Were you using Terminator?

Could you please provide the output of the locale command?

If you encounter any errors, feel free to open an issue in the project, and I will address it as soon as possible. Thank you for contributing to the project!

Screenshot

its-ashu-otf commented 5 months ago

Ahh my bad I just checked my locale and it seems selecting English-India makes locale C.UTF I think thats the reason it was bugging out. locale LANG=C.UTF-8 No worries I will close this PR now.

IamCarron commented 5 months ago

@its-ashu-otf I will try to add support for more locales so this won't happen again, feel free to open an issue on the project, thanks for letting me know about this problem!

its-ashu-otf commented 5 months ago

@its-ashu-otf I will try to add support for more locales so this won't happen again, feel free to open an issue on the project, thanks for letting me know about this problem!

Sure ❤️

digininja commented 5 months ago

I thought there was support for when it didn't get the language.

On Tue, 11 Jun 2024, 21:14 Carrón, @.***> wrote:

@its-ashu-otf https://github.com/its-ashu-otf I will try to add support for more locales so this won't happen again, feel free to open an issue on the project, thanks for letting me know about this problem!

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161533843, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWLUL57B4DJI5WN2WM3ZG5LCFAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGUZTGOBUGM . You are receiving this because you commented.Message ID: @.***>

IamCarron commented 5 months ago

Yep missed that 😅, I will release an update in the next few hours.

digininja commented 5 months ago

Ashutosh, if you want to submit a PR for an Indian translation that would be good.

On Tue, 11 Jun 2024, 21:20 Carrón, @.***> wrote:

Yep missed that 😅, I will release an update in the next few hours.

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161543069, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWO2UF2UZFL4T2ZMNHTZG5LZBAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGU2DGMBWHE . You are receiving this because you commented.Message ID: @.***>

its-ashu-otf commented 5 months ago

Sure I will try

digininja commented 5 months ago

If you could add a translation for the main README at the same time, that would be great.

On Tue, 11 Jun 2024, 21:31 Ashutosh, @.***> wrote:

Sure I will try

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161557221, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWPCAHWWBG77SCMDPWTZG5NARAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGU2TOMRSGE . You are receiving this because you commented.Message ID: @.***>

IamCarron commented 5 months ago

@digininja Fixed - In the previous version, it wasn't considered that the language could arrive empty. There was an 'else' clause that defaulted the script to English, but it wasn't working correctly. Ideally, if the language variable is not recognized or arrives empty, it should always default to English now.

digininja commented 5 months ago

Brilliant, thanks.

On Tue, 11 Jun 2024, 21:49 Carrón, @.***> wrote:

@digininja https://github.com/digininja Fixed - In the previous version, it wasn't considered that the language could arrive empty. There was an 'else' clause that defaulted the script to English, but it wasn't working correctly. Ideally, if the language variable is not recognized or arrives empty, it should always default to English now.

— Reply to this email directly, view it on GitHub https://github.com/digininja/DVWA/pull/639#issuecomment-2161580625, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA4SWKFYQFPZYRNHI36HPTZG5PHPAVCNFSM6AAAAABJE6T3Z2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRGU4DANRSGU . You are receiving this because you were mentioned.Message ID: @.***>