search

digininja / DVWA

Damn Vulnerable Web Application (DVWA)
GNU General Public License v3.0
10.36k stars 3.64k forks source link

Configuration via environment variables #658

Closed adrlsx closed 3 weeks ago

adrlsx commented 3 weeks ago

Full credits to @alles-klar for the original PR #592.

This PR adds the option of configuring DVWA via environment variables. This allows users to change the configuration without rebuilding the Docker image and is particularly useful in a Docker or Kubernetes deployment.

I believe this PR was incorrectly reverted in #605 and was not the cause of #604. The only issue in the original PR came from a mismatch between the environment variable name in config/config.inc.php.dist and in the README.md. The database server variable was changed from DB_SERVER to DVWA_DB_SERVER, which caused some confusion. I've kept the original name of the variable in this PR to avoid any breaking change.

digininja commented 3 weeks ago

Looks good to me, thanks for the update.