digint / btrbk

Tool for creating snapshots and remote backups of btrfs subvolumes
https://digint.ch/btrbk/
GNU General Public License v3.0
1.64k stars 120 forks source link

ssh-agent identities and "no SSH identity provided" #482

Closed wolfgangrupprecht closed 2 years ago

wolfgangrupprecht commented 2 years ago

When using ssh identities and keys stored in the ssh-agent btrbk has no problem logging in and getting the remote snapshots yet the warning still gets printed.

WARNING: No SSH identity provided (option ssh_identity is not set) for: ssh://example/mnt/btr_pool/root

Perhaps the warning could be stored and only printed if the ssh fails?

digint commented 2 years ago

Thanks for reporting!

The idea behind this warning was to simplify first steps, as most users would probably want to set ssh_identity. As it is not required, warning on every run is simply wrong, so I turned it into a hint displayed along with SSH errors:

(note: option "ssh_identity" is not set, using ssh defaults)

fixed in cf2065df308d81f5503d3dc0f0c96cd09d7b9de7, along with some other SSH related improvements I had lying around: