btrbk broken on btrfs-progs 6.1: subvolume has no UUID

Elkropac commented 1 year ago

Hi, my Debian system upgraded btrfs-progs from version 6.0.2 to 6.1 and btrbk stopped working. It says

# btrbk list 
ERROR: Skipping subvolume "/mnt/btrfs/system/system": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/home/homex": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/lxc/lxc/DevelBuster": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/lxc/lxc/DevelStretch": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/lxc/lxc/PHP": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/docker/docker/_scripts": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/docker/docker/gitlab-fresh": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/docker/docker/kibana": subvolume has no UUID
ERROR: Skipping subvolume "/mnt/btrfs/docker/docker/phpdocker": subvolume has no UUID
SOURCE_SUBVOLUME  SNAPSHOT_SUBVOLUME  STATUS  TARGET_SUBVOLUME

after downgrading back to 6.0.2 it works ok again.

My btrbk version is 0.32.5 from Debian unstable

benaryorg commented 1 year ago

Same here on Gentoo with btrfs-progs 6.0.2 vs. 6.1. The issue seems to be independent of kernel versions, I've tried both 5.15.x and 6.1.1.

mm1ke commented 1 year ago

Hi, I can confirm this too. I had the problem on two gentoo system's. Downgrading to btrfs-progs-6.0.1 fixed it for now.

mac-linux-free commented 1 year ago

For me, too an Arch 6.1.1.

ccat3z commented 1 year ago

Upstream issue: https://github.com/kdave/btrfs-progs/issues/562

stevenxxiu commented 1 year ago

Upstream issue: kdave/btrfs-progs#562

Thank you for offering a comment that is actually useful. GitHub has enough +1 "me too" spam that pollutes people's email. Might as well list all the Linux distros out there with a "me too".

benaryorg commented 1 year ago

Upstream issue: kdave/btrfs-progs#562

Looks very much like an issue contained to btrfs-progs specifically then, unrelated to btrbk. I'd suggest closing this issue as no further action should be required on the btrbk side of things (that'd be @Elkropac or a maintainer's responsibility). Furthermore to mitigate the issue I'd also suggest people who are hit by this open a bug with their distro if none exist there already to have btrfs-progs 6.1 properly flagged as bugged and notify them of the upstream issue such that the fix can be packaged as swiftly as possible.

Thank you for offering a comment that is actually useful. […]

Since the referenced upstream issue was literally opened by the person posting the link (thanks for that btw), they've done more than just "offer a comment", they've likely debugged the issue down to where the breakage occurred, hence actually worked on the issue rather than only comment on it.

You, @stevenxxiu, on the other hand, unless I've made a mistake in doing my research, seem to be neither contributor nor maintainer of btrbk or btrfs-progs and your tone very much lacks any politeness whatsoever while offering no further input on the core issue yourself. Thank you for offering your input on reducing noise in discourse, but I would very much like to see you doing this in a way that is either directly constructive (offering alternatives, opening issues for issue templates that already cover the points that were reiterated here,.…) or at least provide your feedback in a polite way ("Please use the thumbs up reaction instead of commenting") instead of fostering a hostile and toxic form of communication. Thank you very much.

stevenxxiu commented 1 year ago

Yes I realize that @ccat3z tried to debug the issue.

or at least provide your feedback in a polite way

Thanks for the input and sorry about my tone. I'll try to be more polite next time. I just see "+1" comments on GitHub way too much, especially on popular projects, that it becomes rather annoying.

digint commented 1 year ago

Thanks for reporting, I will leave this issue open for a while, at least until the regression is fixed in btrfs-progs.

Sadly there is not much that I can do in btrbk: I could check for btrfs-progs version (local as well as remote hosts) and maintain some blacklist, but I don't think this is worth it: the buggy btrfs-progs version will hopefully get removed/superseded in all distros soon.

msmafra commented 1 year ago

Having the same issue on Fedora 37 with Xanmod 6.1.1. Mine is an USB drive and its UUID also changed.

joshuataylor commented 1 year ago

Sorry to add to this post, but if you use ArchLinux, you can do the following:

Check what version of btrfs-progs you currently have:
```
pacman -Qi btrfs-progs | grep Version
```
Version : 6.1-1.1
For x86_64, download https://archive.archlinux.org/repos/2022/12/20/core/os/x86_64/btrfs-progs-6.0.2-1-x86_64.pkg.tar.zst

Note: This might also be in your /var/cache/pacman/pkg/ directory already.
pacman -U btrfs-progs-6.0.2-1-x86_64.pkg.tar.zst
Open /etc/pacman.conf and add btrfs-progs to IgnorePkg, so it won't be upgraded next time you update using your package manager. When this is fixed, you can simply remove it from ignorepkgs.