digint / btrbk

Tool for creating snapshots and remote backups of btrfs subvolumes
https://digint.ch/btrbk/
GNU General Public License v3.0
1.58k stars 116 forks source link

.conf `stream_compress_adapt` documentation and behaviour #551

Closed HaleTom closed 10 months ago

HaleTom commented 10 months ago

The .conf man page says:

       stream_compress_adapt default|<number>
           Enable adaptive compression for <compress_command>. Only supported
           for "zstd" (version >= 1.3.6).

But the code says:

stream_compress_adapt       => { default => undef,         accept => [qw( yes no )] },

From this, I can't work out what the default is, but it's certainly not a number as per the manpage.

This code seems to pass on a "yes" or "no": https://github.com/digint/btrbk/blob/a4d4dff0d12489137aae3d4b629f9c5a5764593c/btrbk#L757-L761

Whereas, zstd manual indicates that it wants:

--adapt[=min=#,max=#]
digint commented 10 months ago

Thanks, the documentation was wrong from the beginning on (see #397), fixed in 18ddc659790de489967c2c82213fb5fba7955d40.

For now, btrbk does not support min/max: probably nobody uses this, do you?

HaleTom commented 10 months ago

On or off is fine for me.

Thanks a bunch!