search

digipolisantwerp / antwerp-ui_angular

Antwerp UI is a component interface library for building user interfaces and responsive web apps.
https://digipolisantwerp.github.io/antwerp-ui_angular
MIT License
13 stars 19 forks source link

Feature/navigation menu #182

Closed MichaelCastiau closed 4 years ago

MichaelCastiau commented 4 years ago

Introduces a new generic navigation menu, featuring an xml like syntax

MichaelCastiau commented 4 years ago

@jsebrech On your comment of the structure: I don't see a large difference other that naming?? The menu-tab & sub-menu-items are very different in nature, as you may have seen if you'd read the code. Changing this would mean a rewrite of half the package.

jsebrech commented 4 years ago

One more remark: there is no link to the navigation-menu README.md from the main README.md, this should be added

jsebrech commented 4 years ago

@jsebrech On your comment of the structure: I don't see a large difference other that naming?? The menu-tab & sub-menu-items are very different in nature, as you may have seen if you'd read the code. Changing this would mean a rewrite of half the package.

I was thinking in terms of having more semantic markup. Right now the implementation details are shining through to the markup that we offer to the developer. But if it's that much work to change it, it's ok for me to leave it as it is.

MichaelCastiau commented 4 years ago

I'm not sure what the culprit is, but the whole website has display issues (horizontal scrollbar) on mobile devices. For the navigation component itself I made most components inline. My general remark is "Try to make your component a bit more universal", because it will be implemented in many apps afterwards. Also, we try to use as few images for documentation as possible (given that it should be clear for screen readers too).

Yes I've noticed the scrolling issues too but it seems unrelated to the navigation menu itself, rather a problem with the viewport.... of the app itself. (scrolling is manually added to make the page fit a mobile screen, .... other nasty 'quickies').

MichaelCastiau commented 4 years ago

I'm not sure what the culprit is, but the whole website has display issues (horizontal scrollbar) on mobile devices. For the navigation component itself I made most components inline. My general remark is "Try to make your component a bit more universal", because it will be implemented in many apps afterwards. Also, we try to use as few images for documentation as possible (given that it should be clear for screen readers too).

Yes I've noticed the scrolling issues too but it seems unrelated to the navigation menu itself, rather a problem with the viewport.... of the app itself. (scrolling is manually added to make the page fit a mobile screen, .... other nasty 'quickies').

This wasn't a problem before, so please fix it.

I'm sorry, I consider this not to be related to the navigation menu itself, but with the general layout setup of the project, so make a separate ticket that can be tracked separately.