Replaced `BrowserModule` with `CommonModule` in the ngx-navigation-me… - Githubissues

digipolisantwerp / antwerp-ui_angular

Antwerp UI is a component interface library for building user interfaces and responsive web apps.

https://digipolisantwerp.github.io/antwerp-ui_angular

MIT License

13 stars 19 forks source link

Replaced `BrowserModule` with `CommonModule` in the ngx-navigation-me… #212

Closed jschoubben closed 4 years ago

jschoubben commented 4 years ago

ngx-navigation-menu

PR Checklist

This PR fulfills the following requirements:

[x] The commit message follows our guidelines: Contributing guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[x] A changelog entry was added

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] angular.io application / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

It is not possible to use the ngx-navigation-menu component inside a lazy-loaded module because it imports BrowserModule

Issue Number: N/A

What is the new behavior?

It doesn't import BrowserModule but instead imports CommonModule which it should do following the Angular Docs.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Resolved issues