digipolisantwerp / antwerp-ui_angular

Antwerp UI is a component interface library for building user interfaces and responsive web apps.
https://digipolisantwerp.github.io/antwerp-ui_angular
MIT License
13 stars 19 forks source link

Context Service: `routerContext` always needs to be true to update the page title #72

Closed lievenvg closed 5 years ago

lievenvg commented 6 years ago

Describe the bug

The routerContext boolean of the Context Service always needs to be set with the value true to update the page title. This should not be needed, because this creates an extra listener on routechange.

To Reproduce

Steps to reproduce the behavior:

  1. Add the ContextModule to your appModule
import { CookieconsentModule } from '@acpaas-ui/ngx-components/layout';

ContextModule.forRoot({
   defaults: {
      title: 'Context title',
   },
   routerContext: true,
}),

Expected behavior

routerContext shouldn't be needed.

OS (please complete the following information):

gerturo commented 5 years ago

Picked up by ACPaaS frontend team

lievenvg commented 5 years ago

Solved in #123