digirati-co-uk / iiif-canvas-panel

Investigation into component granularity
https://iiif-canvas-panel.netlify.app/
MIT License
9 stars 6 forks source link

adds default slot to seq panel #233

Closed bulbil closed 10 months ago

bulbil commented 10 months ago

The issue is that we would like to place controls in a sequence-panel, ideally using exactly the same api as canvas-panel which accepts a default slot (c.f., https://iiif-canvas-panel.netlify.app/docs/applications/simple-viewer-with-common-features).

It may be that I'm missing something but I thought I would try with comically simple, naive approach in case that would suffice. I did a quick test in storybook and it appears to work as expected.

netlify[bot] commented 10 months ago

Deploy Preview for iiif-canvas-panel ready!

Name Link
Latest commit dda431b61156e982e287e725f312cf206f7c00f8
Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel/deploys/659dcca011bcff000871cc03
Deploy Preview https://deploy-preview-233--iiif-canvas-panel.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 10 months ago

Deploy Preview for iiif-canvas-panel-demos ready!

Name Link
Latest commit dda431b61156e982e287e725f312cf206f7c00f8
Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel-demos/deploys/659dcca0421287000823b24c
Deploy Preview https://deploy-preview-233--iiif-canvas-panel-demos.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 10 months ago

Deploy Preview for canvas-panel-storybook canceled.

Name Link
Latest commit dda431b61156e982e287e725f312cf206f7c00f8
Latest deploy log https://app.netlify.com/sites/canvas-panel-storybook/deploys/659dcca08d955b0008b8d9fb
codesandbox-ci[bot] commented 10 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dda431b61156e982e287e725f312cf206f7c00f8:

Sandbox Source
React Configuration
canvas-panel-web-component-demo (image service) (forked) Configuration
simple-vue Configuration
vue-3-carousel Configuration
external-stylesheet-sandbox Configuration
example-sandbox Configuration
custom-preset Configuration
react-choices-example Configuration
reacting-to-the-user Configuration
external-annotation-pages Configuration
virtual-annotation-pages Configuration
loading-annotation-pages Configuration
annotation-display-1 Configuration
annotation-display-2 Configuration
choice-example Configuration
choice-react Configuration
more-regions-1 Configuration
more-regions-2 Configuration
regions-1 Configuration
regions-2 Configuration
regions-3 Configuration
regions-4 Configuration
regions-5 Configuration
regions-6 Configuration
responsive-1 Configuration
stephenwf commented 10 months ago

@bulbil Excellent, thanks for the contribution! There is a pre-release version released using codesandbox that you can test with. But let me know if you need a proper patch on NPM.

bulbil commented 9 months ago

@stephenwf we would need a version to include in a package we are developing -- I don't believe you can do that with codesandbox (as far as I know). A patch would be great!

stephenwf commented 9 months ago

@bulbil If it's still in development, I would recommend using the preview package. Full details can be found here: https://ci.codesandbox.io/status/digirati-co-uk/iiif-canvas-panel/pr/233/builds/458278

If you are using a package manager:

# yarn 1
yarn add https://pkg.csb.dev/digirati-co-uk/iiif-canvas-panel/commit/dda431b6/@digirati/canvas-panel-web-components
# yarn 2, 3
yarn add @digirati/canvas-panel-web-components@https://pkg.csb.dev/digirati-co-uk/iiif-canvas-panel/commit/dda431b6/@digirati/canvas-panel-web-components/_pkg.tgz
# npm
npm i https://pkg.csb.dev/digirati-co-uk/iiif-canvas-panel/commit/dda431b6/@digirati/canvas-panel-web-components

Or if you want to use the bundle directly:

https://pkg.csb.dev/digirati-co-uk/iiif-canvas-panel/commit/dda431b6/@digirati/canvas-panel-web-components/dist/bundle.js
bulbil commented 9 months ago

@stephenwf works for us, I was unfamiliar with codesandbox pr builds.

stephenwf commented 9 months ago

That's great! It just gives you a bit more flexibility if you open a PR that you want to test immediately. Codesandbox should publish those preview packages for all commits.