digirati-co-uk / iiif-canvas-panel

Investigation into component granularity
https://iiif-canvas-panel.netlify.app/
MIT License
9 stars 6 forks source link

guard for mismatched image service dimensions #235

Closed danieltbrennan closed 7 months ago

danieltbrennan commented 7 months ago

This evaluates a canvas resource's embedded image dimensions against what is actually returned by the image service for that resource and adopts the latter should they not match.

netlify[bot] commented 7 months ago

Deploy Preview for iiif-canvas-panel-demos ready!

Name Link
Latest commit 9c942a5c64aced52d1dffac8e0ccdbd16f7925c1
Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel-demos/deploys/65c10fc57d394200084533fa
Deploy Preview https://deploy-preview-235--iiif-canvas-panel-demos.netlify.app/
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 7 months ago

Deploy Preview for iiif-canvas-panel ready!

Name Link
Latest commit 9c942a5c64aced52d1dffac8e0ccdbd16f7925c1
Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel/deploys/65c10fc5aff0e30008ae7396
Deploy Preview https://deploy-preview-235--iiif-canvas-panel.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 7 months ago

Deploy Preview for canvas-panel-storybook canceled.

Name Link
Latest commit 9c942a5c64aced52d1dffac8e0ccdbd16f7925c1
Latest deploy log https://app.netlify.com/sites/canvas-panel-storybook/deploys/65c10fc50da49c0008d6d35e
codesandbox-ci[bot] commented 7 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9c942a5c64aced52d1dffac8e0ccdbd16f7925c1:

Sandbox Source
React Configuration
canvas-panel-web-component-demo (image service) (forked) Configuration
simple-vue Configuration
vue-3-carousel Configuration
external-stylesheet-sandbox Configuration
example-sandbox Configuration
custom-preset Configuration
react-choices-example Configuration
reacting-to-the-user Configuration
external-annotation-pages Configuration
virtual-annotation-pages Configuration
loading-annotation-pages Configuration
annotation-display-1 Configuration
annotation-display-2 Configuration
choice-example Configuration
choice-react Configuration
more-regions-1 Configuration
more-regions-2 Configuration
regions-1 Configuration
regions-2 Configuration
regions-3 Configuration
regions-4 Configuration
regions-5 Configuration
regions-6 Configuration
responsive-1 Configuration
stephenwf commented 7 months ago

Thanks @danieltbrennan, aside from changing to !== for consistency - it looks good to merge. Did this fix the issue you ran into in #229 ?

danieltbrennan commented 7 months ago

Thanks @stephenwf, just made that update. Yes, based on what I'm seeing when testing with these types of images in storybook this should resolve that issue.