Open stephenwf opened 7 months ago
Name | Link |
---|---|
Latest commit | ce917efa1f1410e816ecfe93030e646b2a53a438 |
Latest deploy log | https://app.netlify.com/sites/iiif-canvas-panel/deploys/666b3e70c84a480008f1024d |
Name | Link |
---|---|
Latest commit | ce917efa1f1410e816ecfe93030e646b2a53a438 |
Latest deploy log | https://app.netlify.com/sites/iiif-canvas-panel-demos/deploys/666b3e701c510400080707e9 |
Name | Link |
---|---|
Latest commit | ce917efa1f1410e816ecfe93030e646b2a53a438 |
Latest deploy log | https://app.netlify.com/sites/canvas-panel-storybook/deploys/666b3e70619dfe00088364aa |
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit ce917efa1f1410e816ecfe93030e646b2a53a438:
Sandbox | Source |
---|---|
simple-vue | Configuration |
vue-3-carousel | Configuration |
external-stylesheet-sandbox | Configuration |
example-sandbox | Configuration |
custom-preset | Configuration |
react-choices-example | Configuration |
reacting-to-the-user | Configuration |
external-annotation-pages | Configuration |
virtual-annotation-pages | Configuration |
loading-annotation-pages | Configuration |
annotation-display-1 | Configuration |
annotation-display-2 | Configuration |
choice-example | Configuration |
choice-react | Configuration |
more-regions-1 | Configuration |
more-regions-2 | Configuration |
regions-1 | Configuration |
regions-2 | Configuration |
regions-3 | Configuration |
regions-4 | Configuration |
regions-5 | Configuration |
regions-6 | Configuration |
responsive-1 | Configuration |
@abrin I'm almost finished this refactor, which includes a better build system.
I've published a temporary package, which has the new code (most recent main was merged in too).
canvas-panel-neo@1.0.1
Would it be possible for you to test this package and let me know if it continue to work as expected with your build tooling? The updates and compatibility are worth the update (in my opinion).
@stephenwf will do. @danieltbrennan is in the image viewer today and will give it a spin
@stephenwf testing this and was able to build in our component without any problems at that step. So far though noticing an issue where the behavior of paged manifests as loaded with sequence-panel seems to have changed, notably that the first standalone page is being included again within the first pair of open pages. See below from our storybook:
Will test more but this is the first thing that caught my eye when running through our Storybook. Some fixtures for that type of manifest if useful:
https://data.getty.edu/media/manifest/bayard-custom (prezi v3) https://media.getty.edu/iiif/manifest/2629d5fa-fb10-4b33-a9f9-59f053bf5604 (prezi v2)
Oh that is strange. I'll double check the changes. It does seem to be working in another viewer that uses the same sequence calculations, it must be a key or cache somewhere. I'll have a look into it!
Great news about the build changes though! That will hopefully make this a smooth transition, and much easier to iterate I hope.
Summary of changes:
@iiif/vault
->@iiif/helpers
@iiif/vault-helpers
->@iiif/helpers
@atlas-viewer/atlas
bumped to v2.x (currently a PR branch)@iiif/parser
bumped to v2.x@iiif/presentation-3
bumped to v2.xreact-iiif-vault
bumped to v1.xIn practice this will mean a few updates to the sandboxes.
Is now:
Or just:
A lot of changes under the hood, but no changes to the API. (Vault, React IIIF Vault or Helpers)