digirati-co-uk / iiif-canvas-panel

Investigation into component granularity
https://iiif-canvas-panel.netlify.app/
MIT License
9 stars 6 forks source link

clean build of touch interactions #265

Closed abrin closed 4 months ago

abrin commented 4 months ago

this provides a clean build of the updated atlas logic with the approprate attributes to enable/disable the touch-interaction features.

netlify[bot] commented 4 months ago

Deploy Preview for iiif-canvas-panel failed.

Name Link
Latest commit
Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel/deploys/6672004670b58f5cec9eb665
netlify[bot] commented 4 months ago

Deploy Preview for iiif-canvas-panel-demos ready!

Name Link
Latest commit e8e7b42f26d4eae98cc0b094b5c48c79ae47d780
Latest deploy log https://app.netlify.com/sites/iiif-canvas-panel-demos/deploys/666b5876f6cc8b00089cef2b
Deploy Preview https://deploy-preview-265--iiif-canvas-panel-demos.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 months ago

Deploy Preview for canvas-panel-storybook failed.

Name Link
Latest commit e8e7b42f26d4eae98cc0b094b5c48c79ae47d780
Latest deploy log https://app.netlify.com/sites/canvas-panel-storybook/deploys/666b5876a07990000839ac8d
codesandbox-ci[bot] commented 4 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e8e7b42f26d4eae98cc0b094b5c48c79ae47d780:

Sandbox Source
simple-vue Configuration
vue-3-carousel Configuration
external-stylesheet-sandbox Configuration
example-sandbox Configuration
custom-preset Configuration
react-choices-example Configuration
reacting-to-the-user Configuration
external-annotation-pages Configuration
virtual-annotation-pages Configuration
loading-annotation-pages Configuration
annotation-display-1 Configuration
annotation-display-2 Configuration
choice-example Configuration
choice-react Configuration
more-regions-1 Configuration
more-regions-2 Configuration
regions-1 Configuration
regions-2 Configuration
regions-3 Configuration
regions-4 Configuration
regions-5 Configuration
regions-6 Configuration
responsive-1 Configuration
abrin commented 4 months ago

@stephenwf is it possible to check if in Netlify the build is set to use node 16 or an older version? My guess is that's the core source of the issue Screenshot 2024-06-18 at 2 43 41 PM

stephenwf commented 4 months ago

I've tried that - but I think most dependencies now require higher than 16. Need to update the broken dependencies. Let's see what the build does 👍

stephenwf commented 4 months ago

Hmm, it seemed to ignore the change to the netlify config - still used v18 (.nvmrc?)

stephenwf commented 4 months ago

Do you want to merge this now? I'll look at the storybook later

abrin commented 4 months ago

I think we're ready here if you are

abrin commented 4 months ago

I've tried that - but I think most dependencies now require higher than 16. Need to update the broken dependencies. Let's see what the build does 👍

sorry, was just spitballing

stephenwf commented 4 months ago

Published as @digirati/canvas-panel-web-components@1.0.67 🎉

abrin commented 4 months ago

thank you!