digirati-co-uk / prezi2to3-js

Converted https://github.com/IIIF/prezi-2-to-3 to javascript
MIT License
4 stars 0 forks source link

If there's only 1 sequence in a manifest the properties of the sequence disappear after transformation. #4

Closed 4d4mm closed 6 years ago

4d4mm commented 6 years ago

Sequence metadata ignored:

import Upgrader from 'iiif-prezi2to3';

let uri = "http://iiif.io/api/presentation/2.1/example/fixtures/21/manifest.json";
let upgrader = new Upgrader({"deref_links " : false});
let resultObject = upgrader.processUri(uri, true);

Sequence viewingDirection ignored:

import Upgrader from 'iiif-prezi2to3';

let uri = "http://iiif.io/api/presentation/2.1/example/fixtures/22/manifest.json";
let upgrader = new Upgrader({"deref_links " : false});
let resultObject = upgrader.processUri(uri, true);

Sequence viewingHint ignored:

import Upgrader from 'iiif-prezi2to3';

let uri = "http://iiif.io/api/presentation/2.1/example/fixtures/23/manifest.json";
let upgrader = new Upgrader({"deref_links " : false});
let resultObject = upgrader.processUri(uri, true);

Current Behavior

If a manifest contains only one sequence the sequence object with all of its properties getting ignored, no range being created.

Possible Solution

Sequences with metadata, viewingDirection, viewingHint, etc. shouldn't be ignored.

4d4mm commented 6 years ago

fixed in https://www.npmjs.com/package/iiif-prezi2to3/v/1.0.8.