search

digirati-co-uk / prezi2to3-js

Converted https://github.com/IIIF/prezi-2-to-3 to javascript
MIT License
4 stars 0 forks source link

Missing Ids #7

Open stephenwf opened 6 years ago

stephenwf commented 6 years ago

Source: http://preview.iiif.io/api/image-prezi-rc1/api/presentation/3.0/#a-summary-of-metadata-requirements

Expected Behavior

The following types all have mandatory IDs: Collection Manifest Canvas Annotation Range Annotation Collection Content Resources (various types)

Also, it is recommended that Annotation Page has an ID. Its not known if services require IDs, but it would make sense.

Current Behavior

Missing IDs on content resources, services and annotation pages.

Possible Solution

Generate IDs either from naming convention: https://{resourceId}/{type}/{accumulator}

Or from a hash, with configurable base: https://{resourceId}/{hash}

Screenshots

N/A

Desktop (please complete the following information):

N/A

Additional context

Related PR: https://github.com/stephenwf/iiif-redux/pull/126 where Presentation 3 resources are normalised into id maps in redux state.

4d4mm commented 6 years ago

fixed in https://www.npmjs.com/package/iiif-prezi2to3/v/1.0.8.