search

digirati-co-uk / timeliner

IIIF Timeliner
https://iiif-timeliner.netlify.com
MIT License
11 stars 7 forks source link

Selecting 2 bubbles to group them is zooming in #278

Closed mcwhitaker closed 5 years ago

mcwhitaker commented 5 years ago

We are supposed to zoom in only the user requests it by clicking on the correct icon/gadget/button.

villedigirati commented 5 years ago

The SoW specified this behaviour, unless it was misunderstood by us: "Zoom to selection – as it works in the old timeliner. If multiple bubbles are selected, the zoomed area goes from the beginning of the first bubble to the end of the last bubble."

and we had a ticket for this before:

https://github.com/digirati-co-uk/timeliner/issues/195

mcwhitaker commented 5 years ago

Yes, I can see why the confusion. What I meant was that the zoom feature would not just zoom in x%, it would zoom to the selected bubbles. My assumption that as it works in the old timeliner was understandable was not a good assumption. Sorry about that.

villedigirati commented 5 years ago

Ok so zooming must always be activated implicitly by using the zoom controls, but selecting multiple bubbles will constrain the zoomable area to those bubbles.

mcwhitaker commented 5 years ago

I think you meant explicitly in your comment above. Yes, explicitly.

villedigirati commented 5 years ago

Yes sorry! Doh!

cjcolvar commented 5 years ago

@mcwhitaker We've fixed this locally in our fork. https://github.com/IUBLibTech/timeliner/pull/7

stephenwf commented 5 years ago

Hi @cjcolvar removing the saga will not fix the initial requirement of this behaviour when clicking on the "zoom in" button

cjcolvar commented 5 years ago

@stephenwf @mcwhitaker I see that I didn't read the full issue thread. To be clear, I agree that that PR does not add the requested behavior of zoom to selection, but it does fix the original issue of zooming when selecting multiple bubbles.