search

digisavvy / some-like-it-neat

A WordPress Theme Using _s, Bourbon + Neat and Theme Hook Alliance
GNU General Public License v2.0
276 stars 61 forks source link

Fix Bourbon Neat import paths #106

Closed jacobarriola closed 8 years ago

jacobarriola commented 8 years ago

The import paths in the Sass files were incorrect, causing compile errors.

digisavvy commented 8 years ago

Hey @jacobarriola buddy, thanks for these. Anyway I can get you to submit these against the development branch so I can test? =)

digisavvy commented 8 years ago

Also, on this item, there are two node packages I'm aware of bourbon and bourbon-neat. These should work well. What are you seeing, @jacobarriola?

digisavvy commented 8 years ago

Thanks again. =)

jacobarriola commented 8 years ago

@digisavvy the node package name for Neat is called node-neat, which contains bourbon-neat within its own node_modules dir. It's listed in your devDependencies object within your packages.json file.

The import path in _app.scss is looking for node_modules/bourbon/, which doesn't exist. The import path in_grid-settings.scss is looking for node_modules/bourbon-neat/, which doesn't exist as well. It should be node_modules/node-neat/node_modules/bourbon-neat/.

As a result, I'm getting Sass errors because the files cannot be found.