search

digisavvy / some-like-it-neat

A WordPress Theme Using _s, Bourbon + Neat and Theme Hook Alliance
GNU General Public License v2.0
276 stars 61 forks source link

"Proudly powered" footer text #48

Closed justintadlock closed 9 years ago

justintadlock commented 9 years ago

In footer.php, you have this text:

<?php printf( __( 'Proudly powered by <span class="genericon genericon-wordpress"></span> %s', 'digistarter' ), 'WordPress' ); ?>

There are a couple of issues worth thinking about with this. 1) Always avoid HTML in translations if possible (things can get messed up). 2) It's OK to allow "WordPress" to be translated.

There are a couple of options to consider. The first is my preference:

<?php printf( __( 'Proudly powered by %s WordPress', 'digistarter' ), '<span class="genericon genericon-wordpress"></span>' ); ?>

<?php _e( 'Proudly powered by <span class="genericon genericon-wordpress"></span> WordPress', 'digistarter' ); ?>
digisavvy commented 9 years ago

Thank you! Learning all sorts of new stuff.