digistump / DigistumpArduino

Files to add Digistump support (Digispark, Pro, DigiX) to Arduino 1.6.X (1.6.5+)
934 stars 377 forks source link

WString.h: add c_str() method as in upstream. #100

Closed domschl closed 2 years ago

domschl commented 4 years ago

From: https://github.com/arduino/ArduinoCore-avr/blob/2f67c916f6ab6193c404eebe22efe901e0f9542d/cores/arduino/WString.h#L163

ArminJo commented 4 years ago

Makes no sense to add only one fuction of all the missing ones.

domschl commented 4 years ago

This one function allows to to implement many of the missing ones, because it allows access to the string content. So that's why in my opinion it makes sense to merge this one-liner.

ArminJo commented 4 years ago

OK youre right! But I would prefer a complete revision of the string class to integrate, not only one line. Thanks