search

digital-analytics-program / gov-wide-code

Provides a set of javascript files and documentation to implement web analytics on US federal websites
http://www.digital.gov/dap
100 stars 50 forks source link

Use consistent styling for code - this is mostly cosmetic #67

Closed eddietejeda closed 1 year ago

eddietejeda commented 5 years ago

I noticed inconsistencies in styling, the use of tabs and spaces, bracketing, new lines. I used https://github.com/airbnb/javascript for inspiration, although it's not strict. A future commit will include .eslintrc.js file to clean up code further.

Given that this was a styling and formatting clean up, this code should not have an impact on functionality. Since there are no tests, having more eyes look over the code and test it out would be helpful. I advise others look over the changes and test it.

tdlowden commented 5 years ago

thanks much! while the code is posted here, we work with the vendor to make any changes and push to our central host location afterward. i am sending this for their awareness, and if they agree, we will move to include these changes in v4.1.

eddietejeda commented 5 years ago

where does this stand?