search

digital-analytics-program / gov-wide-code

Provides a set of javascript files and documentation to implement web analytics on US federal websites
http://www.digital.gov/dap
102 stars 54 forks source link

Add support for eslint and basic configuration file to detect issues #69

Closed eddietejeda closed 1 year ago

eddietejeda commented 6 years ago

This commit is dependent on https://github.com/digital-analytics-program/gov-wide-code/pull/68 which adds package.json file to repostory.

This goes a bit further and add eslint package and basic configuration.

Running eslint reveals a number of remaining formatting issues, dead code paths and undefined variables. We will clean that up in the future.

tdlowden commented 6 years ago

i'm relatively sure this is copacetic. @konklone, if you get a moment, could you also take a glance?

konklone commented 6 years ago

@tdlowden I left a few comments noting things, and it would be good if you or e-NOR could fold the updating of package.json into the overall release workflow, but in general I don't see anything here that will disrupt DAP.

tdlowden commented 6 years ago

thanks for your comments @konklone. I'll give it a bit for @eddietejeda to respond to your other comments. Assuming those are answered, I'll merge