make acquisition time an input to lifecycle functions - Githubissues

digital-asset / contingent-claims

Apache License 2.0

5 stars 0 forks source link

make acquisition time an input to lifecycle functions #101

Closed matteolimberto-da closed 2 years ago

matteolimberto-da commented 2 years ago

make acquisition time an input to lifecycle functions
remove intrinsic acquisition time

Happy to hear your thoughts on this PR.

In my opinion it has the advantage of

removing complexity from the library (no intrinsicAcquisitionTime)
making all contracts well-defined (e.g. Scale ..., Or ...)

If you are happy with this change, it might be a good time to push it as we already broke the API