digital-asset / contingent-claims

Apache License 2.0
5 stars 0 forks source link

doc CI job failing #103

Closed lucianojoublanc-da closed 2 years ago

lucianojoublanc-da commented 2 years ago

https://app.circleci.com/pipelines/github/digital-asset/contingent-claims/755/workflows/1958bb06-4185-4f32-8623-661bdd9d2a15/jobs/1218

I think this is due to a bad directory for the cache step in the .circleci/config.yml script. It should be .docs instead of docs

lucianojoublanc-da commented 2 years ago

@brianweir-da I think it's this change that broke it: 9d69e0b4

The following change may be enough to fix it, but I haven't looked into it further. https://github.com/digital-asset/contingent-claims/tree/circleci-editor/286/master

brian-weir commented 2 years ago

I think your fix @lucianojoublanc-da is correct - can you create a PR for it and I'll approve it? If it doesn't fix it, I can investigate it further and rectify it.

I didn't realise the docs where being generated off the back of a release in CC.

matteolimberto-da commented 2 years ago

Called for victory too early, the updated doc does not seem to be pushed to the github-pages branch. From: https://app.circleci.com/pipelines/github/digital-asset/contingent-claims/763/workflows/2d5d5c66-2cda-46b4-bf2e-567f8b471713/jobs/1230

./scripts/publish-api-doc.sh
Branch 'github-pages' set up to track remote branch 'github-pages' from 'origin'.
Switched to a new branch 'github-pages'
On branch github-pages
Your branch is up to date with 'origin/github-pages'. 

Untracked files:
  (use "git add <file>..." to include in what will be committed)
    .daml/

nothing added to commit but untracked files present (use "git add" to track) CircleCI received exit code 0

matteolimberto-da commented 2 years ago

False alarm, the docs hadn't actually changed. Thanks @brianweir-da for pointing this out. Closing the issue for good.