search

digital-asset / da-marketplace

BSD Zero Clause License
17 stars 13 forks source link

Syndication - next iteration #459

Closed GeorgSchneider closed 2 years ago

GeorgSchneider commented 2 years ago

Apologies for the huge size - this PR covers: FL-34, FL-173, FL-42, FL-41, FL40, FL-169, FL-171.

Best reviewed by going through each commit related to a given ticket.

Commit for FL-137 and FL-138 is not tagged with the ticket number. It's this one: Support multiple accounts per provider and selection of settlement ac...

judywu-da commented 2 years ago

@dorrit-du-da @georg-da I have done reviewing commits https://github.com/digital-asset/da-marketplace/pull/459/commits/35403fa46e00a087bec2a809bbf211bd55c19781 and https://github.com/digital-asset/da-marketplace/pull/459/commits/1b4cc4ea1e4f6ffb25879df09ca9a160221b9c60 I have one question, Does callable flag means whether the issuer can early redeem the bond (does it restrict whether the investor can redeem the bond? Can the investor always early redeem regardless of the flag?

GeorgSchneider commented 2 years ago

@judywu-da Yes, the issuer has to specify upfront if it's a callable bond (ie. issuer-redeemable). The investor can always request early/partial redemption, but the issuer is free to reject those. This is making some assumptions as to how the bond terms are defined, we might have to revisit if actual requirements are different (eg. bond can only be called on certain dates).

judywu-da commented 2 years ago

@georg-da closing this PR and remove syndication-next branch as it is replaced by syndication-dev