search

digital-asset / daml-finance

Apache License 2.0
17 stars 16 forks source link

single-maintainer instruction #1116

Closed johan-da closed 11 months ago

johan-da commented 11 months ago

FIXES https://github.com/digital-asset/daml-finance/issues/1112

This PR splits up the requestors : Parties into a single-maintainer of the key called instructor : Party, and additional signatories called consenters : Parties.

In particular, this affects Instruction, Batch, Settlement.Factory, and the InstructionKey.

Additionally, I replaced providers : Parties in the Claim rule implementation to provider : Party (to more easily be able to assign the instructor in some flows).

Follow up: Consider to replace providers : Parties to provider : Party for the other Rules as well (i.e., Distibution and Replacement). Currently, those are always instantiated with single parties in our test scripts.

johan-da commented 11 months ago

corresponding changes for the quick-starter scripts: https://github.com/digital-asset/daml-finance/pull/1117