Simplify adding a new RC Daml SDK snapshot in Daml Finance

digital-asset / daml-finance

Apache License 2.0

17 stars 16 forks source link

Simplify adding a new RC Daml SDK snapshot in Daml Finance #1224

Open markus-da opened 3 days ago

markus-da commented 3 days ago

This used to work out of the box, but as of SDK 2.9.0 RC1 our daml.nix throws an error:


Installing with internal version file /tmp/nix-build-daml-sdk-2.9.0-snapshot.20240619.12850.0.v0cfddd39.drv-0/daml/daml_version.txt: 2.9.0-rc1
ERROR: both --install-with-internal-version and --install-with-custom-version flags were supplied

markus-da commented 1 day ago

There is a new version logic in the Daml SDKs, especially for release candidates. We should:

[x] change our daml.nix to follow the new logic
[x] do the same in the bin/update-daml-hashes script
[x] document how our daml.yaml variables should be set for RCs vs production SDKs