search

digital-asset / daml-finance

Apache License 2.0
17 stars 16 forks source link

`Daml.Finance.Account.Account` path is very confusing #515

Open lucianojoublanc-da opened 1 year ago

lucianojoublanc-da commented 1 year ago

The double Account in the path is easy to miss (in addition you have the Account type which would mean that a fully qualified import would be Daml.Finance.Account.Account.Account!). This seems to be necessary because it sits in it's own package (see #102), but this shouldn't leak into the module namespace.

I'm not really sure of the best way to go about resolving this.

matteolimberto-da commented 1 year ago

Client code would not generally import this module (at least according to our advertised development pattern).

lucianojoublanc-da commented 11 months ago

This has struck again. It's being in the use of the interface i.e. Daml.Finance.Interface.Account.Account:Account.

matteolimberto-da commented 11 months ago

I think this can be addressed once we get the new multi-package feature. We currently need the above structure in order to map our .daml file to the correct package via symlinks.