digital-asset / daml-finance

Apache License 2.0
17 stars 16 forks source link

Align Daml Finance snapshot numbers #879

Open markus-da opened 1 year ago

markus-da commented 1 year ago

Align Daml Finance docs.daml.com pre-release (snapshot) numbers to “company standard” on the form -snapshot.20230531.10456.0.v26f31ff7

Currently, these are only used as version number on docs.daml.com: https://github.com/digital-asset/docs.daml.com/blob/main/docs/2.7.0/versions.json

markus-da commented 1 year ago

Currently, this is specified in the main Daml Finance daml.yaml: https://github.com/digital-asset/daml-finance/blob/pre-rel-20230615/daml.yaml

Seems this type of snapshot number is not supported in a daml.yaml, so this would require some development.

garyverhaegen-da commented 1 year ago

Currently, this is specified in the main Daml Finance daml.yaml: https://github.com/digital-asset/daml-finance/blob/pre-rel-20230615/daml.yaml

Seems this type of snapshot number is not supported in a daml.yaml, so this would require some development.

Indeed, the format in daml.yaml is derived from ghc and is basically just \d+[.\d+]*.

garyverhaegen-da commented 1 year ago

(Therefore aligning is not possible, in case that wasn't clear.)