Closed bame-da closed 2 years ago
My preference here is still to kill daml ledger navigator
/make it simply redirect to daml navigator
. The only thing that daml ledger navigator
does at this point is to read the deploy
section from daml.yaml
and you’re overwriting that so you gain nothing by using it over daml navigator
.
The other difference is that daml ledger navigator
always reads the parties from the running ledger, whereas daml navigator
takes them form daml.yaml
.
But I agree that we should consolidate the two and that daml navigator
is more in line with the rest of the assistant.
I guess what's missing from daml navigator
is an ability to start it outside of a project directory and have it read the parties from the ledger.
I guess what's missing from daml navigator is an ability to start it outside of a project directory and have it read the parties from the ledger.
That’s not true. See release notes for SDK 1.8.0
If no parties are in the Navigator config or daml.yaml, Navigator will now pick up parties from the party management service. Those parties are periodically refreshed.
daml ledger navigator
only passes -ignore-project-parties
to daml navigator
so it always ignores the daml.yaml
file. Apart from that, they are identical wtr to parties.
I think we should just deprecate the parties
field in daml.yaml
. It servers no useful purpose and doesn’t work with implicit party allocation. An init-script
is a better solution for allocating a set of parties initially.
Yes, but that doesn't work outside a project. If you try to use daml navigator server
outside a project (ie in the absence of a daml.yaml
, you get:
No configuration file found!
Please specify a configuration file and restart Navigator.
Config file path was 'DefaultConfig(ui-backend.conf)'.
Hint: use the create-config command to create a sample config file.
I think if we just made that behave the same as daml navigator server
in a project with no parties specified, we could deprecate daml ledger navigator
.
Oh I see, so we just need to default to an empty config file. Easy enough.
Opened https://github.com/digital-asset/daml/issues/10516 for the config file stuff.
The config file stuff has been merged so daml navigator server
works fine outside of a project now.
daml ledger navigator is dead.
The way to set both the ledger and navigator port with
daml ledger navigator
is currentlyI'd prefer having different names for the two ports.