search

digital-asset / daml

The Daml smart contract language
https://www.digitalasset.com/developers
Other
802 stars 204 forks source link

replace nullable `ExercisedEvent#getInterfaceId` with an Optional property #14483

Closed S11001001 closed 2 years ago

S11001001 commented 2 years ago

We generally use Optional in the Java event model, e.g. CreatedEvent#agreementText. ExercisedEvent#interfaceId is an exception. We should give the property type Optional<Identifier> instead.

cocreature commented 2 years ago

If you remove it before interface GA you can avoid the whole deprecation dance which seems preferable.

stefanobaghino-da commented 2 years ago

@S11001001 As mentioned by @cocreature, I agree the backward compatibility concern doesn't apply to features that are not even available outside of Daml-LF 1.dev. Feel free to adjust the description of the ticket but make sure to add a changelog entry for users that might already be playing around with interfaces to let them know of the adjustment.